Remove patch for building OVAs using content library #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
|
/hold for testing |
abhay-krishna
force-pushed
the
remove-content-library-patch
branch
2 times, most recently
from
754780f to
3ebbb05
Compare
|
/unhold |
vignesh-goutham
approved these changes
Mar 8, 2024
abhay-krishna
force-pushed
the
remove-content-library-patch
branch
from
3ebbb05 to
f29aa7f
Compare
abhay-krishna
force-pushed
the
remove-content-library-patch
branch
from
f29aa7f to
5af7232
Compare
vignesh-goutham
approved these changes
Mar 8, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abhay-krishna
force-pushed
the
remove-content-library-patch
branch
from
5af7232 to
ea78dfb
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the patch that configures Packer to upload OVAs to a content library. Since we now build in the Colo lab, we can build them without first exporting to content libraries.
Testing
Built on Colo with content library
Built on Colo without content library
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.